[PATCH] D91211: [mlir][Inliner] Refactor the inliner to use nested pass pipelines instead of just canonicalization

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 12:39:32 PST 2020


rriddle added a comment.

In D91211#2423773 <https://reviews.llvm.org/D91211#2423773>, @mehdi_amini wrote:

> I don't quite get why you have to keep a separate builder callback for the default pass manager and build it on demand and cache it on every new encountered op name, why not just relying on the client adding it to the `opPipelines` `StringMap`with an empty key for instance?

The problem is that, at present, a PassManager can't be constructed to run on any operation. It always requires the type of the operation that it is going to be scheduled on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91211/new/

https://reviews.llvm.org/D91211



More information about the llvm-commits mailing list