[PATCH] D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 12:13:35 PST 2020
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
In D92113#2423616 <https://reviews.llvm.org/D92113#2423616>, @rahmanl wrote:
> Thank you for the comments @MaskRay . Are there any style guidelines for the test files? I wasn't able to find anything online.
Thanks for the update. There is no official style guideline. I just improved my way adding tests by learning from others who are nitpicking (commendatory term here!) on tests.
I requested `{{$}}` because the section directive may have `,unique,N` suffixes and without `{{$}}` you could not check that no `,unique,N` occurred.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92113/new/
https://reviews.llvm.org/D92113
More information about the llvm-commits
mailing list