[PATCH] D91960: [llvm][unittests] Fix protential nullptr dereferences due to unchecked return value or EXPECT_* macro

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 11:44:49 PST 2020


vsk added a comment.

Hi @OikawaKirie, thanks for the patch! Would you mind splitting up this patch? This should make each individual patch easier to review, and make it possible for changes to land incrementally (& faster). Generally we ask for patches to be split up into self-contained units: it's not an exact science, but splitting things up by directory might be a reasonable heuristic to start with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91960/new/

https://reviews.llvm.org/D91960



More information about the llvm-commits mailing list