[PATCH] D92038: [lld][WebAssembly] Ensure stub symbols always get address 0

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lld/test/wasm/weak-undefined-pic.s:30
+
+# Verify that we do not generate dynamnic relocations for the GOT entry.
+
----------------




================
Comment at: lld/test/wasm/weak-undefined-pic.s:71
+
+# With `-pie` or `-shared` the resolution should is defered to the dynamic
+# linker and the function address should be imported as GOT.func.foo.
----------------



================
Comment at: lld/wasm/Symbols.h:162
+  // called) and should otherwise be treated as missing/undefined.  See
+  // SymbolTable::replaceWithUndefined.
+  bool isStub : 1;
----------------
If getting slot 0 (and comparing equal to the nullptr) is also a requirement for stub functions then that should maybe be mentioned here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92038/new/

https://reviews.llvm.org/D92038