[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

aside from some nits, lgtm
thanks for doing this!



================
Comment at: clang/test/Frontend/optimization-remark-line-directive.c:5
 
-// RUN: %clang_cc1 %s -Rpass=inline -debug-info-kind=line-tables-only -emit-llvm-only -verify -fno-experimental-new-pass-manager
+// RUN: %clang_cc1 %s -Rpass=inline -debug-info-kind=line-tables-only -emit-llvm-only -verify -fno-experimental-new-pass-manager -mllvm -mandatory-inlining-first=0
 
----------------
the change on this line shouldn't be necessary, this is a legacy PM RUN line


================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:27
 
 /// There are 3 scenarios we can use the InlineAdvisor:
 /// - Default - use manual heuristics.
----------------
aeubanks wrote:
> 4
ping


================
Comment at: llvm/test/Transforms/Inline/pr46945.ll:1-2
-; RUN: opt %s -o - -S -passes=inliner-wrapper | FileCheck %s
+; RUN: opt %s -o - -S -passes=always-inliner-wrapper | FileCheck %s
+; RUN: opt %s -o - -S -passes=inliner-wrapper | FileCheck %s -check-prefix=BASELINE
 
----------------
maybe we should have a RUN line with `-passes='default<O2>'` to make sure the whole thing works


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91567/new/

https://reviews.llvm.org/D91567