[PATCH] D92335: [ThinLTO] Import symver directives for imported symbols (PR48214)

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 10:56:52 PST 2020


hans created this revision.
hans added reviewers: tejohnson, pcc.
Herald added subscribers: dmgreen, steven_wu, hiraditya, inglorion.
Herald added a project: LLVM.
hans requested review of this revision.

To make sure any symver information is not lost when importing a symbol, always write the symver metadata in the thinlto bitcode file (not just for split lto), and check it when importing symbols, adding to the destination module's inline asm as needed.

(I'm new to this part of the code, so please give me pointers on how I can turn this into something that's fit for landing.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92335

Files:
  llvm/lib/Linker/IRMover.cpp
  llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  llvm/test/ThinLTO/X86/Inputs/import-symver-foo.ll
  llvm/test/ThinLTO/X86/import-symver.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/symver.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92335.308425.patch
Type: text/x-patch
Size: 4213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201130/b29210e2/attachment.bin>


More information about the llvm-commits mailing list