[PATCH] D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D92134#2423302 <https://reviews.llvm.org/D92134#2423302>, @akhuang wrote:

> In D92134#2417347 <https://reviews.llvm.org/D92134#2417347>, @rnk wrote:
>
>> Well, I *can* think of a way to test this from a .s file. Instead of using .cv_inline_line_table, you could use a sequence of `.byte 0xNN, 0xNN` directives. I think you can get the hex codes from llvm-pdbutil dump -symbols. How about it?
>
> How does this work? If I just add `.byte`s they turn into instructions. Or does it need to start with a particular .byte sequence?

If you set up a regular S_INLINESITE record in codeview, and then replace the `.cv_inline_line_table` directive with raw bytes, you can more finely control the opcodes used to produce the binary annotations. You'd get rid of the associated .cv_loc directives for the inline site as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92134/new/

https://reviews.llvm.org/D92134