[PATCH] D91928: [nvptx] Skip alloca for read-only byval arguments.
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 10:43:34 PST 2020
tra added a comment.
In D91928#2410288 <https://reviews.llvm.org/D91928#2410288>, @hliao wrote:
> yeah, it seems the other approach is more appropriate to place the `alloca` in the frontend and that explicitly copy from the parameter space to the private space.
+1. Inserting alloca+copy early would be beneficial in general -- it will face more optimization opportunities which should be possible to see-through the copy in some cases.
Adding `readonly` on the original argument would probably be good, too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91928/new/
https://reviews.llvm.org/D91928
More information about the llvm-commits
mailing list