[PATCH] D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns
    Matt Arsenault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Nov 30 10:38:10 PST 2020
    
    
  
arsenm added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:782
     }
+    case GIM_CheckI64ImmArgPredicate: {
+      int64_t InsnID = MatchTable[CurrentIdx++];
----------------
Should probably group with    case GIM_CheckI64ImmPredicate: {
The name similarity is a bit confusing too
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91703/new/
https://reviews.llvm.org/D91703
    
    
More information about the llvm-commits
mailing list