[PATCH] D91836: [PowerPC] Delete remnant Darwin code in PPCAsmParser

Mon Nov 30 10:05:33 PST 2020

nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2021

-/// createPPCAsmPrinterPass - Returns a pass that prints the PPC assembly code
-/// for a MachineFunction to the given output stream, in a format that the
----------------
MaskRay wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > nickdesaulniers wrote:
> > > > void wrote:
> > > > > Was this intentional?
> > > > I agree with @void , we should keep the comment but drop the `, in a format that the Darwin assembler can deal with.`
> > > This is intentional. Personally I don't think the comment is of any value. The purpose is obvious from its name.
> > > 
> > > `create*AsmPrinterPass` is also in AMDGPUAsmPrinter.cpp, which does not have a comment.
> > Ping
> @nickdesaulniers 🙄
I would prefer you didn't remove the entire comment but,

"or enter. I'm a sign, not a cop"
https://imgur.com/gallery/mSHi8

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91836/new/

https://reviews.llvm.org/D91836