[PATCH] D92323: [WebAssembly][MC] Fix placement of table section

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 07:23:24 PST 2020


sbc100 added inline comments.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1814
     writeFunctionSection(Functions);
+    writeTableSection(Tables);
     // Skip the "memory" section; we import the memory instead.
----------------
I don't understand how moving the table section before Events and Globals relates to being able to use externref and funcref as block types.

Aren't all types defined in the type section?   And also.. the blocks themselves are all defined in Code section which is after all of these isn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92323/new/

https://reviews.llvm.org/D92323



More information about the llvm-commits mailing list