[PATCH] D92180: Speedup some unicode rendering

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/lib/Support/Unicode.cpp:359
+    if (Length == 1) {
+      if (!isprint(Text[i]))
+        return ErrorNonPrintableCharacter;
----------------
aguinet wrote:
> According to `isprint` man page, the result depends on the current locale. Is this the behavior we want? Maybe checking for the printable ASCII character range "by hand" would make this code more portable?
correct, I'll add that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92180/new/

https://reviews.llvm.org/D92180