[PATCH] D92317: [LV] ExtractValue instruction costs

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 06:30:30 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6858
+    // Assume we need 1 instruction to extract a value from a vector.
+    return 1;
   default:
----------------
fhahn wrote:
> Better to use `TTI.getVectorInstrCost`? And perhaps also handle `InsertValue`?
Yeah, cheers, will look/do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92317/new/

https://reviews.llvm.org/D92317



More information about the llvm-commits mailing list