[PATCH] D92320: [WebAssembly][lld] Fix call-indirect.s test to validate

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 06:28:50 PST 2020


wingo created this revision.
wingo added a reviewer: sbc100.
Herald added subscribers: llvm-commits, ecnelises, sunfish, jgravelle-google, dschuff.
Herald added a project: LLVM.
wingo requested review of this revision.
Herald added a subscriber: aheejin.

Add missing address operand, so that we can validate the output files.

Depends on D92315 <https://reviews.llvm.org/D92315>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92320

Files:
  lld/test/wasm/Inputs/call-indirect.s
  lld/test/wasm/call-indirect.ll
  lld/test/wasm/compress-relocs.ll


Index: lld/test/wasm/compress-relocs.ll
===================================================================
--- lld/test/wasm/compress-relocs.ll
+++ lld/test/wasm/compress-relocs.ll
@@ -22,5 +22,5 @@
 
 ; ERROR: wasm-ld: error: --compress-relocations is incompatible with output debug information. Please pass --strip-debug or --strip-all
 
-; CHECK:    Body:            2802808880800011808080800080808080001A2802848880800011818080800080808080001A0B
-; COMPRESS: Body:            280280081100001A280284081101001A0B
+; CHECK:    Body:            41002802808880800011808080800080808080001A41002802848880800011818080800080808080001A0B
+; COMPRESS: Body:            4100280280081100001A4100280284081101001A0B
Index: lld/test/wasm/call-indirect.ll
===================================================================
--- lld/test/wasm/call-indirect.ll
+++ lld/test/wasm/call-indirect.ll
@@ -122,7 +122,7 @@
 ; CHECK-NEXT:         Body:            42010B
 ; CHECK-NEXT:       - Index:           1
 ; CHECK-NEXT:         Locals:
-; CHECK-NEXT:         Body:            2802808880800011808080800080808080001A2802848880800011818080800080808080001A0B
+; CHECK-NEXT:         Body:            41002802808880800011808080800080808080001A41002802848880800011818080800080808080001A0B
 ; CHECK-NEXT:       - Index:           2
 ; CHECK-NEXT:         Locals:
 ; CHECK-NEXT:         Body:            41020B
Index: lld/test/wasm/Inputs/call-indirect.s
===================================================================
--- lld/test/wasm/Inputs/call-indirect.s
+++ lld/test/wasm/Inputs/call-indirect.s
@@ -7,9 +7,11 @@
   .globl  call_bar_indirect
 call_bar_indirect:
   .functype call_bar_indirect () -> ()
+  i32.const 0
   i32.load  indirect_bar
   call_indirect () -> (i64)
   drop
+  i32.const 0
   i32.load  indirect_foo
   call_indirect () -> (i32)
   drop


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92320.308355.patch
Type: text/x-patch
Size: 1843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201130/dfe898c0/attachment.bin>


More information about the llvm-commits mailing list