[PATCH] D91894: [lld-macho] Implement -fatal_warnings

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/MachO/Options.td:611
-     Flags<[HelpHidden]>,
-     Group<grp_rare>;
 def no_eh_labels : Flag<["-"], "no_eh_labels">,
----------------
int3 wrote:
> thakis wrote:
> > int3 wrote:
> > > these groups are based on the groups used in the ld64 manpage. I think we should keep them, though I wouldn't object to defining a new group if you think it'd be more fitting
> > Oh, turns out this one can stay grp_rare, put it back. What confused me was that grp_undocumented causes warnings, so I had to remove grp_undocumented on `-demangle` in D91884. Which group should I use for that one?
> hmm I had a look at the current set of possible groups and none of them look like a great fit. However, `grp_rare` does seem to be a dumping ground for a variety of options that don't seem rare so much as miscellaneous. I guess we could put `-demangle` there too.
> 
> Another option would be to create a new group, e.g. `grp_diagnostics`, and put things like `-fatal_warnings` and `-demangle` there. I'm fine with either.
grp_rare kind of fits for `-demangle`, but clang passes it on literally every single lld invocation, so it isn't "rare" in the english meaning of that word. Not sure we care. If there's no explicit group, it shows up in the "OPTIONS" category, which is where old mach-o lld has it, which seems like a decent fit to me as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91894/new/

https://reviews.llvm.org/D91894