[PATCH] D91894: [lld-macho] Implement -fatal_warnings

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 05:22:41 PST 2020


thakis added inline comments.


================
Comment at: lld/MachO/Options.td:611
-     Flags<[HelpHidden]>,
-     Group<grp_rare>;
 def no_eh_labels : Flag<["-"], "no_eh_labels">,
----------------
int3 wrote:
> these groups are based on the groups used in the ld64 manpage. I think we should keep them, though I wouldn't object to defining a new group if you think it'd be more fitting
Oh, turns out this one can stay grp_rare, put it back. What confused me was that grp_undocumented causes warnings, so I had to remove grp_undocumented on `-demangle` in D91884. Which group should I use for that one?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91894/new/

https://reviews.llvm.org/D91894



More information about the llvm-commits mailing list