[PATCH] D90479: [ValueTracking] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 04:58:11 PST 2020
spatel added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1011-1012
// the best folding opportunity.
if (Known.hasConflict())
Known.setAllZero();
return;
----------------
I'm not sure if it changes anything directly here, but we should revisit this conflict logic (similarly at the final block in the function) because we have a poison value in IR with D71126 (see also D92270).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90479/new/
https://reviews.llvm.org/D90479
More information about the llvm-commits
mailing list