[PATCH] D92305: [llvm-objdump] Document --mattr=help in --help output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 04:16:40 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, once the two suggestions have been addressed.



================
Comment at: llvm/test/tools/llvm-objdump/mattr-mcpu-help.test:7
+# CHECK: Available features for this target:
+# To check we still disassemble the file
+# CHECK: file format elf64-x86-64
----------------
Most newer binutils tests are using '##' as comment markers to help the comment stand out from the FileCheck and lit directives.


================
Comment at: llvm/test/tools/llvm-objdump/mattr-mcpu-help.test:10
+
+!ELF
+FileHeader:
----------------
Not strictly required, but it enables users to add more yaml documents to the test should it ever get extended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92305/new/

https://reviews.llvm.org/D92305



More information about the llvm-commits mailing list