[PATCH] D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 04:06:46 PST 2020


zatrazz added a comment.

In D92241#2421377 <https://reviews.llvm.org/D92241#2421377>, @MaskRay wrote:

> Is https://reviews.llvm.org/D91733#2407055 resolved?

That is my aim by changing how the tests are built by enabling _Float16 per architecture bases with:

  if (${arch} MATCHES "arm|aarch64|arm64" AND COMPILER_RT_HAS_FLOAT16)
    list(APPEND BUILTINS_TEST_TARGET_CFLAGS -DCOMPILER_RT_HAS_FLOAT16)
    string(REPLACE ";" " " BUILTINS_TEST_TARGET_CFLAGS "${BUILTINS_TEST_TARGET_CFLAGS}")
  endif()

On compiler-rt/test/builtins/CMakeLists.txt (I am assuming the tests are always built with the resulting
built clang). Do you see another case where I should handle as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92241/new/

https://reviews.llvm.org/D92241



More information about the llvm-commits mailing list