[PATCH] D92305: [llvm-objdump] Document --mattr=help in --help output
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 03:16:08 PST 2020
jhenderson added a comment.
It's probably worth writing a test that shows how --mattr=help behaves (if it isn't tested already), given that it is being documented. If you'd prefer to do that in a separate patch, that's fine by me, or you can do it as part of this patch. The test would not want to be much more than that the help is printed when requested (it doesn't need to test the contents of the help output).
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:233
cl::list<std::string> objdump::MAttrs("mattr", cl::CommaSeparated,
- cl::desc("Target specific attributes"),
+ cl::desc("Target specific attributes (--mattr=help for details)"),
cl::value_desc("a1,+a2,-a3,..."),
----------------
Please run clang-format on the modified code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92305/new/
https://reviews.llvm.org/D92305
More information about the llvm-commits
mailing list