[PATCH] D92237: [SCEVExpander] NFCI: Change Cost type in costAndCollectOperands from int -> unsigned.

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 03:09:11 PST 2020


CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2345
     SmallPtrSetImpl<const SCEV *> &Processed,
     SmallVectorImpl<SCEVOperand> &Worklist) {
   const SCEV *S = WorkItem.S;
----------------
Should we not add the test  //SubtractFromBudget(BudgetRemaining, Cost); //
here too?
Because removing the test (BudgetRemaining<0) from here it may change the code path, and something that in the past could return true, now may return false because of the two tests below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92237/new/

https://reviews.llvm.org/D92237



More information about the llvm-commits mailing list