[PATCH] D92305: [llvm-objdump] Document --mattr=help in --help output

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 02:51:39 PST 2020


DavidSpickett created this revision.
Herald added subscribers: llvm-commits, rupprecht.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
Herald added a project: LLVM.
DavidSpickett requested review of this revision.

This does the same as `--mcpu=help` but was only
documented in the user guide.

Also corrected the single dash in `-mcpu=help` text.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92305

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -226,11 +226,11 @@
                         cl::Grouping, cl::aliasopt(MachOOpt));
 
 cl::opt<std::string> objdump::MCPU(
-    "mcpu", cl::desc("Target a specific cpu type (-mcpu=help for details)"),
+    "mcpu", cl::desc("Target a specific cpu type (--mcpu=help for details)"),
     cl::value_desc("cpu-name"), cl::init(""), cl::cat(ObjdumpCat));
 
 cl::list<std::string> objdump::MAttrs("mattr", cl::CommaSeparated,
-                                      cl::desc("Target specific attributes"),
+                                      cl::desc("Target specific attributes (--mattr=help for details)"),
                                       cl::value_desc("a1,+a2,-a3,..."),
                                       cl::cat(ObjdumpCat));
 
Index: llvm/docs/CommandGuide/llvm-objdump.rst
===================================================================
--- llvm/docs/CommandGuide/llvm-objdump.rst
+++ llvm/docs/CommandGuide/llvm-objdump.rst
@@ -156,7 +156,7 @@
 
 .. option:: --mattr=<a1,+a2,-a3,...>
 
-  Enable/disable target-specific attributes. Specify ``--mcpu=help`` to display
+  Enable/disable target-specific attributes. Specify ``--mattr=help`` to display
   the available attributes.
 
 .. option:: --no-leading-addr


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92305.308300.patch
Type: text/x-patch
Size: 1438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201130/b2b2b041/attachment.bin>


More information about the llvm-commits mailing list