[PATCH] D91994: [AArch64] Cortex-R82: remove crypto

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 01:55:11 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:54
               AArch64::AEK_SHA2 | AArch64::AEK_AES  | AArch64::AEK_I8MM))
 AARCH64_ARCH("armv8-r", ARMV8R, "8-R", "v8r",
              ARMBuildAttrs::CPUArch::v8_R, FK_CRYPTO_NEON_FP_ARMV8,
----------------
chill wrote:
> chill wrote:
> > This change here modifies the architecture option. If a core does not completely implement an architecture, nevertheless
> > the `-march=that-architecture` option should be not be affected.
> > 
> s/should be not be /should not be/
Ah yes, this indeed doesn't look right. Will address this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91994/new/

https://reviews.llvm.org/D91994



More information about the llvm-commits mailing list