[PATCH] D92208: [AArch64][CostModel] Fixed costs for mul <2 x i64>

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:645
+    auto *VecTy = dyn_cast<FixedVectorType>(Ty);
+    bool IsInt64 = Ty->getScalarType()->isIntegerTy(64);
+    if (VecTy && IsInt64)
----------------
dmgreen wrote:
> I think this can just use LT.second == MVT::v2i64? (Otherwise it needs to account for scalable vectors, but dealing with the MVT is probably simpler).
I have kept the check as it was because it checks for FixedVectorType, so looks correct to me, and with checking for MVT::v2i64 we would miss out on MVT::v4i64, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92208/new/

https://reviews.llvm.org/D92208