[PATCH] D92259: [ELF] Make foo@@v1 resolve undefined foo at v1

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1924
+    // truncated at '@' by Symbol::parseSymbolVersion().
+    StringRef name = sym->getName();
+    const char *end1 = name.data() + name.size();
----------------
Should we add something like `Symbol::getFullName` or `Symbol::getVersionedName`?
The code like `const char *end1 = name.data() + name.size()` looks hacky. I'd isolate it.


================
Comment at: lld/ELF/Driver.cpp:1926
+    const char *end1 = name.data() + name.size();
+    if (*end1 != '@' || end1[1] == '@')
+      continue;
----------------
I'd suggest this change here and below for conisistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92259/new/

https://reviews.llvm.org/D92259