[PATCH] D90418: [debuginfo] Vectorizing a loop doesn't terminate all vectorized variable locations

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/pr39018.ll:32
+  %2 = bitcast [192 x i32]* %1 to i8*, !dbg !20
+  call void @llvm.lifetime.start.p0i8(i64 768, i8* nonnull %2) #3, !dbg !20
+  call void @llvm.dbg.declare(metadata [192 x i32]* %1, metadata !13, metadata !DIExpression()), !dbg !21
----------------
We are usually able to remove  llvm.lifetime.start/end intrinsics from the debug info related tests.


================
Comment at: llvm/test/Transforms/LoopVectorize/pr39018.ll:70-73
+attributes #0 = { norecurse nounwind readnone uwtable}
+attributes #1 = { argmemonly nounwind willreturn }
+attributes #2 = { nounwind readnone speculatable willreturn }
+attributes #3 = { nounwind }
----------------
I guess we don't need these attributes.


================
Comment at: llvm/test/Transforms/LoopVectorize/pr39018.ll:108
+!28 = distinct !DILexicalBlock(scope: !19, file: !8, line: 9, column: 3)
+!29 = !{!30, !30, i64 0}
+!30 = !{!"int", !31, i64 0}
----------------
I think we can remove these !tbaa metadata.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90418/new/

https://reviews.llvm.org/D90418