[PATCH] D92274: [lld/mac] Add --reproduce option

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/Common/Reproduce.cpp:61
+      v.push_back(' ');
+    v+= quote(arg.getValue(i));
+  }
----------------
thakis wrote:
> (Turns out neither ELF nor COFF ports have MultiArg<> flags. Covered by the `-platform_version` flag in the test.)



================
Comment at: lld/MachO/DriverUtils.cpp:118
+    case OPT_o:
+      os << "-o " << quote(sys::path::filename(arg->getValue())) << "\n";
+      break;
----------------



================
Comment at: lld/MachO/InputFiles.h:40
 
+// If -reproduce option is given, all input files are written
+// to this tar archive.
----------------



================
Comment at: lld/test/MachO/reproduce.s:33
+# RSP2-NOT:  {{^}}repro2{{[/\\]}}
+# RSP2: {{[/\\]}}foo.o
+
----------------
nit: align with previous line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92274/new/

https://reviews.llvm.org/D92274