[PATCH] D91836: [PowerPC] Delete remnant Darwin code in PPCAsmParser
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 29 21:05:45 PST 2020
MaskRay added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2021
-/// createPPCAsmPrinterPass - Returns a pass that prints the PPC assembly code
-/// for a MachineFunction to the given output stream, in a format that the
> MaskRay wrote:
> > nickdesaulniers wrote:
> > > void wrote:
> > > > Was this intentional?
> > > I agree with @void , we should keep the comment but drop the `, in a format that the Darwin assembler can deal with.`
> > This is intentional. Personally I don't think the comment is of any value. The purpose is obvious from its name.
> > `create*AsmPrinterPass` is also in AMDGPUAsmPrinter.cpp, which does not have a comment.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits