[PATCH] D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 29 19:40:22 PST 2020


craig.topper added a comment.

In D76127#2421901 <https://reviews.llvm.org/D76127#2421901>, @TOCK wrote:

> @danilaml
> +1. It looks like a workaround at the moment.
>
> @lebedev.ri
> I'm not aware of any in-tree intrinsic affected. The affected one I found is generated by some testing tool.

Probably no in-tree intrinsic is affected because the current code causes SelectionDAGBuilder to generate broken code. I believe this is the FIXME on int_x86_sse_ldmxcsr in llvm/include/IR/IntrinsicsX86.td


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76127/new/

https://reviews.llvm.org/D76127



More information about the llvm-commits mailing list