[PATCH] D16474: Use PC-relative address for x32 TLS address

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 29 13:06:11 PST 2020

hvdijk added a comment.

In D16474#2421640 <https://reviews.llvm.org/D16474#2421640>, @RKSimon wrote:

> @hvdijk Are you in a position to commandeer this phab revision and complete @hjl.tools's work?

Yes, I think so. I took a look at the ISel failure, but that cannot be fixed independently, fixing that by itself results in invalid machine instructions because of the use of `$ebx` without any definition, exactly what this diff fixes. I would say this diff should be updated to apply to current LLVM and then committed without a test. This is a trivial change: we still need to change the condition to `if (Subtarget->is32Bit())` exactly as in this diff, but the `else` block is no longer there after r359318, it has been moved into `getAddressOperands` in a way that already respects `N`'s type, so that part of the diff can just be removed. Then, once that is in, I can create a new diff for the ISel failure and include a test in that. Does that sound okay?



More information about the llvm-commits mailing list