[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 28 17:20:09 PST 2020

Paul-C-Anagnostopoulos added a comment.

The TypeOf_xxx field is only used by the searchable tables backend. My trek through all the backends revealed it as the only one that needs to distinguish string and code, because it can emit the C++ initializer for any type of field. All the other backends know what is in each field they process. You can see from the various patches that there is nothing special about code fields in the other backends.

I will fix the lint issues. I will let this stew here for a few days in case there are other comments.

(A new !replace operator, along with !lookup, are on my to-do list.)

Comment at: llvm/test/TableGen/generic-tables.td:138
+  string TypeOf_Kind = "CEnum";
+////  GenericEnum TypeOf_Kind = CEnum;
I will get rid of this line.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list