[PATCH] D92269: [TableGen] Eliminate the 'code' type

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 28 14:23:58 PST 2020


jrtc27 added a comment.

Losing types and permitting nonsensical operators like `!subst` on code seems a bit sad. Why not just define a `!codeconcat`, like how we have a separate `!listconcat`? I agree that the TypeOf_xxx stuff is really ugly and so having _greater_ expressivity like `!codeconcat` would go a long way to help that. Also, `cast<code>(str)` would be the natural way to express the cases where you still really do want to construct code as a string without needing TypeOf_xxx.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92269/new/

https://reviews.llvm.org/D92269



More information about the llvm-commits mailing list