[PATCH] D92059: [SLP] Control maximum vectorization factor from TTI

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added a comment.

> Not sure how appropriate is it to commit a target test using llc into the Transforms directory.

You are probably right - perhaps it is enough to run opt and add a comment that explains that the CHECKed instructions would result in spilling



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:129
 
+static cl::opt<unsigned>
+MaxVFOption("slp-max-vf", cl::init(0), cl::Hidden,
----------------
maybe include "slp" in the description as well, to be really clear..?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:748
 
+  unsigned getMaximumVF(unsigned ElemWidth, unsigned Opcode) const {
+    unsigned MaxVF = MaxVFOption.getNumOccurrences() ?
----------------
Is there a reason for having the default TTI value of 0 instead of UINT_MAX directly as you first suggested?




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92059/new/

https://reviews.llvm.org/D92059