[PATCH] D91936: [BasicAA] Fix BatchAA results for phi-phi assumptions

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 29 01:38:34 PST 2020


nikic planned changes to this revision.
nikic added a comment.

This will clearly need something more sophisticated. After thinking this over, I also think that the current approach of inserting assumptions at phis is not optimal, as the tests added in https://github.com/llvm/llvm-project/commit/b5e8de9c7903d458b098a8af03939384270c1a5e show. I expect this can also result in BatchAA returning different results, depending on whether a gep or a phi is visited first. We should be inserting everything as NoAlias into the cache in the first place and tracking whether that assumption gets used or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91936/new/

https://reviews.llvm.org/D91936



More information about the llvm-commits mailing list