[PATCH] D65603: Add support in CMake to statically link the C++ standard library.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 28 21:39:50 PST 2020
MaskRay added a comment.
In D65603#1625980 <https://reviews.llvm.org/D65603#1625980>, @erichkeane wrote:
> Does anyone have issues with this? Can I commit it?
I think the problem is that LLVM_STATIC_LINK_CXX_STDLIB may be too niche. Do people want to set CMAKE_SHARED_LINKER_FLAGS at the same time? On Linux, unless you set `LIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY`, `-static-libstdc++ -stdlib=libc++` does not really work. Considering all these, I do not know whether the configure time variable pulls its weight. Personally I'd avoid such complexity.
CHANGES SINCE LAST ACTION
More information about the llvm-commits