[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 18:56:21 PST 2020


Meinersbur added a comment.

Looking at `CodeGenFunction::GenerateOpenMPCapturedVars`, the condition `if (!CurField->getType()->isAnyPointerType())` seems to match what is done here, but I wonder whether it is always necessary. Is the additional indirection necessary for pointer-sized data types (e.g. `intptr_t`, or smaller)?

Aside this optimization, the change looks like something has to be done. Can you update the naming conventions pointed-out by clang-tidy?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92189/new/

https://reviews.llvm.org/D92189



More information about the llvm-commits mailing list