[PATCH] D92246: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.getLogicalNOT
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 27 13:43:16 PST 2020
lebedev.ri added a comment.
In D92246#2420760 <https://reviews.llvm.org/D92246#2420760>, @laytonio wrote:
> I'm not sure I understand the concern here. If its just the requirement to specify a VT, maybe we should add an overload of getLogicalNOT that doesn't require one? (and maybe getNOT while we're at it) It seems reusing the VT of whatever you're flipping is probably what you want most of the time anyway.
I agree that this is an NFC change, i'm just not sold that more lines of code is better.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits