[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:407
 public:
-  uint8_t geNumberOfVRSaved() const;
+  uint8_t getNumberOfVRSaved() const;
   bool isVRSavedOnStack() const;
----------------
DiggerLin wrote:
> for the function name , I already has the separate patch for it. https://reviews.llvm.org/D92225 . 
Please rebase the patch on D92225 when you have the chance.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:35
+CHECK-NEXT:      b8: 00                           # Version = 0
+CHECK-NEXT:      b9: 00                           # Language = C
+CHECK-NEXT:      ba: 2a                           # -isGlobalLinkage, -isOutOfLineEpilogOrPrologue, +hasTraceBackTableOffset
----------------
The `=` with space is not consistent in the printing. Please only use with one style here.
I think we should choose between 
```
# xx = xxx
```
or
```
# xx=xxx
```
Have a slight preference on the first one. 


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:36
+CHECK-NEXT:      b9: 00                           # Language = C
+CHECK-NEXT:      ba: 2a                           # -isGlobalLinkage, -isOutOfLineEpilogOrPrologue, +hasTraceBackTableOffset
+CHECK-NEXT:                                         -isInternalProcedure, +hasControlledStorage, -isTOCless
----------------
I think it's still a tad too long for this line. Perhaps it's better to move `+hasTraceBackTableOffset` to the next line.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:51
+CHECK-NEXT:      d4: 00 00 01 00                    ControlledStorageInfoDisp[2]=256
+CHECK-NEXT:      d8: 00 03 66 6f                  # FunctionNameLen =3; FunctionName =foo
+CHECK-NEXT:      dc: 6f
----------------
Please print the FunctionNameLen and FunctionName in separate lines.
In this case:
```
d8: 00 03            # FunctionNameLen = 3
da: 66 6f 6f         # FunctionName = foo
```


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:57
+CHECK-NEXT:      e0: c0 00 00 00                  # VectorParmsInfoString=vf
+CHECK-NEXT:      e4: 20                           # ExtensionTable =32
+CHECK-NEXT:             ...
----------------
It would be great if we could decode this field for user, just like the `Language` field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049