[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-invalid-traceback-table.test:3
+
+# RUN: llvm-objdump -D --traceback-table --symbol-description %p/Inputs/xcoff-invalid-traceback-table.o | \
+# RUN:   FileCheck %s
----------------
daltenty wrote:
> Should we be expecting a non-zero exit code here?
when traceback parse error.  we just a warning and raw data of traceback table. not exit and continue to parse other part of the object file.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:144-146
+    OS << "\tWarning: Parse traceback table failure!(The value in error msg is "
+          "calculated based on traceback begin) \n";
+    OS << "\tError msg: " << toString(TTOrErr.takeError());
----------------
jhenderson wrote:
> Please report warnings/errors properly, as per what all tools do, rather than print them inline with the disassembly. See also the bit on warning/error guidelines in the coding standards too.
we do not want report and errror 


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:144-146
+    OS << "\tWarning: Parse traceback table failure!(The value in error msg is "
+          "calculated based on traceback begin) \n";
+    OS << "\tError msg: " << toString(TTOrErr.takeError());
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Please report warnings/errors properly, as per what all tools do, rather than print them inline with the disassembly. See also the bit on warning/error guidelines in the coding standards too.
> we do not want report and errror 
the design purpose as , when parse error on the traceback table, we just emit a warning and print the information out and then continue to parse other part of the xcoff object file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049