[PATCH] D92224: [llvm-readelf] - Switch to using from `reportWarning` to `reportUniqueWarning` in `DynRegionInfo`.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 27 05:54:17 PST 2020
grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.
grimar requested review of this revision.
This is a part of the plan we had previously to convert all calls to
`reportUniqueWarning` and then rename it to just `reportWarning`.
I was a bit unsure about this particular change at first, because it doesn't add a
new functionality: seems it is impossible to trigger a warning duplication currently.
At the same time I find the idea of the plan mentioned very reasonable.
And with that we will be sure that `DynRegionInfo` can't report duplicate
warnings, what looks like a nice feature for possible refactorings and further tool development.
Depends on D92218 <https://reviews.llvm.org/D92218>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4413 bytes
Desc: not available
More information about the llvm-commits