[PATCH] D92154: [AArch64] Add custom lowering for ISD::ABS
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 27 05:03:58 PST 2020
dmgreen added a comment.
OK thanks. Custom lowering via abs is probably equal to or better than a dag combine as far as I understand, considering we should have enough combines for ABS.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3981
+ // Generate SUBS & CSEL.
+ SDValue Cmp =
Can we just generate a SUBS (which becomes the CMP) and a CSNEG directly? That should avoid needing to create the two sub's I think.
CHANGES SINCE LAST ACTION
More information about the llvm-commits