[PATCH] D91957: [Analysis] Migrate more high level cost functions to using InstructionCost

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 04:26:57 PST 2020


david-arm updated this revision to Diff 308020.
david-arm added a subscriber: paulwalker-arm.
david-arm added a comment.

- After some private discussions with @paulwalker-arm I think that we shouldn't rely upon the comparison operators treating invalid costs as infinite. Instead it's better to explicitly check for validity before comparing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91957/new/

https://reviews.llvm.org/D91957

Files:
  llvm/include/llvm/Analysis/CodeMetrics.h
  llvm/include/llvm/Analysis/InstructionCost.h
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Transforms/Utils/LoopRotationUtils.h
  llvm/lib/Analysis/CodeMetrics.cpp
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
  llvm/lib/Transforms/Scalar/LoopDataPrefetch.cpp
  llvm/lib/Transforms/Scalar/LoopFlatten.cpp
  llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
  llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
  llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
  llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp
  llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp
  llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp
  llvm/unittests/Transforms/Utils/LoopRotationUtilsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91957.308020.patch
Type: text/x-patch
Size: 25363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201127/b6891ec4/attachment.bin>


More information about the llvm-commits mailing list