[PATCH] D92218: [llvm-readelf/obj] - Move unique warning handling logic to the `ObjDumper`.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. The inline suggestion probably deserves a separate patch. Might want to wait and give others an opportunity to chime in, especially as it's Thanksgiving weekend in the US.



================
Comment at: llvm/tools/llvm-readobj/ObjDumper.cpp:43-44
+  handleAllErrors(std::move(Err), [&](const ErrorInfoBase &EI) {
+    cantFail(WarningHandler(EI.message()),
+             "WarningHandler should always return ErrorSuccess");
+  });
----------------
Maybe we could simplify this by having `WarningHandler` not return an Error at all? What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92218/new/

https://reviews.llvm.org/D92218