[PATCH] D84846: [MC] Add support for generating missing GNU build notes

Timm B├Ąder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 02:03:21 PST 2020


tbaeder added a comment.

In D84846#2396303 <https://reviews.llvm.org/D84846#2396303>, @MaskRay wrote:

> https://fedoraproject.org/wiki/Toolchain/Watermark Seems that `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on its own is probably not that useful. `.gnu.linkonce` is a proto-comdat legacy feature which the patch should ignore.

I can update the patch to ignore .gnu.linkonce. As for annobin, it can also be used as a clang plugin these days.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84846/new/

https://reviews.llvm.org/D84846



More information about the llvm-commits mailing list