[PATCH] D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 01:57:40 PST 2020

CarolineConcatto added a comment.

Thank you @samparker  for your review. I agree with you that we should also test the code path of  **getCmpSelInstrCost **and** getArithmeticInstrCost**, but at the moment these code paths were/are broken for scalable vector.
We are working to make these paths work for scalable vectors by replacing FixedVector with VectorType and using the ElementType class. 
These will be addressed in upcoming patches. I don’t think that we should fix these code paths in this patch because the chain to fix it is long and will make the patch long and complex
What I can do is add tests with XFAIL for now, and remove in the future.
Is this a good solution for now?

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list