[PATCH] D92183: [DAG] Legalize umin(x,y) -> sub(x,usubsat(x,y)) and umax(x,y) -> add(x,usubsat(y,x)) iff usubsat is legal

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:26969
-  if (VT == MVT::v8i16) {
-    assert((Opcode == ISD::UMIN || Opcode == ISD::UMAX) &&
-           "Unexpected MIN/MAX opcode");
----------------
pengfei wrote:
> Nit: is it better to remove the custom declaration for them?
That's the plan (see D91876) - theres a horrible set of isOperationLegalOrCustom dependencies on other opcode expansions that I'm working to get fixed once and for all. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92183/new/

https://reviews.llvm.org/D92183