[PATCH] D91028: [llvm-objcopy][NFC] replace class Buffer/MemBuffer/FileBuffer with streams.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 27 00:27:33 PST 2020
jhenderson added a comment.
In D91028#2410699 <https://reviews.llvm.org/D91028#2410699>, @avl wrote:
> update for Note 3. It was considered to be not useful to implement reserve() method as fixed-size memory-mapped file(D91693 <https://reviews.llvm.org/D91693>). Instead it was suggested to implement resizable raw_mmap_ostream.
> Thus, if we need to have memory mapped file for objcopy then we have this alternative - implement resizable raw_mmap_ostream.
FYI, I'm holding off reviewing this patch further (and I'd recommend others do the same personally) until we've sorted out D91693 <https://reviews.llvm.org/D91693>, as I think that will continue to have an impact on this patch.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits