[PATCH] D92073: [CodeGen] Add text section prefix for COFF object file
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 26 22:34:53 PST 2020
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM. You'd better wait few days to see if others object. Thanks.
Comment at: llvm/test/CodeGen/X86/text-section-prefix.ll:9
+;; CHECK hot section name
+; SECTION-HOT-ELF: .section .text.hot
+; SECTION-HOT-COFF: .section .text$hot
> pengfei wrote:
> > You don't need to distinguish `HOT` and `UNLIKLY` since they are in different functions. You just need `SECTION-ELF` and `SECTION-COFF`.
> > You may also need to add
> > ```
> > ; RUN: llc -mtriple x86_64-linux-gnu -unique-section-names=0 %s -o - | FileCheck %s --check-prefix=ELF-NOUNIQ
> > ; RUN: llc -mtriple x86_64-windows-mingw64 %s -o - | FileCheck %s --check-prefix=MINGW
> > ```
> > as Reid suggested.
> Thanks for your review comments! I removed HOT and UNLIKELY, and added ELF-NOUNIQ and MINGW, could you please have a look?
Nit: It seems no difference between `MSVC` and `MINGW`, you can use `COFF` for both to reduce the duplicated check.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits