[PATCH] D91983: [PowerPC] Fix missing nop after call to weak callee.
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 26 12:30:46 PST 2020
NeHuang added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-calls.ll:26
-; Calls to weak function requires a TOC restore 'nop' with the small codemodel
+; Calls to weak function requires a TOC restore 'nop' with all codemodels
; because the definition that gets choosen at link time may come from a
----------------
nit code models
================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-calls.ll:33
+; CHECK: bl foo_weak
+; CHECK: nop
----------------
Should we put a `CHECK-NEXT` here
================
Comment at: llvm/test/CodeGen/PowerPC/preemption.ll:231
; CHECK: bl weak_local_function
-; CHECK-NOT: nop
+; CHECK: nop
; CHECK: blr
----------------
should we put a `CHECK-NEXT` here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91983/new/
https://reviews.llvm.org/D91983
More information about the llvm-commits
mailing list