[PATCH] D92162: [LangRef] Add poison constant

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 11:35:03 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/docs/LangRef.rst:3660
 
+A poison value is a result of an erroneous operation.
 In order to facilitate speculative execution, many instructions do not
----------------
Would personally drop this sentence, seems pretty vague.


================
Comment at: llvm/docs/LangRef.rst:3735
       %poison = sub nuw i32 0, 1           ; Results in a poison value.
+      %poison2 = sub i32 poison, 1         ; Also results in a poison value.
       %still_poison = and i32 %poison, 0   ; 0, but also poison.
----------------
%poison2 is already used below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92162/new/

https://reviews.llvm.org/D92162



More information about the llvm-commits mailing list